Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct delete[] use #629

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Correct delete[] use #629

merged 1 commit into from
Jul 14, 2016

Conversation

ideasman42
Copy link
Collaborator

No description provided.

@ideasman42 ideasman42 added the bug label Jul 12, 2016
@yamisama
Copy link

Thanks for your work, it's greatly appreciated!

One thing though: I think it might be better to replace these with appropriate STL smart pointers instead of explicit delete[] operators. That way, the probability of introducing similar memory leaks in the future would be reduced (like for example when someone decides to use another return statement somewhere earlier in the function without realizing there is cleanup to do), and it would also make the code exception safe.

@skitaoka
Copy link
Member

Jenkins, test this.

@skitaoka
Copy link
Member

I also prefer to use shared pointers; however I merge this PR because fixing bugs is top priority.

@skitaoka skitaoka merged commit 87094db into opentoonz:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants