Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #790

Merged
merged 1 commit into from Sep 8, 2016
Merged

Typos #790

merged 1 commit into from Sep 8, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 5, 2016

Resolves: #787

I bulk-replaced all simmetrics and lenght

I'll fix the wrong ones and squash it later.

UPDATE: Done.

UPDATE 2 & 2.5: Attempted to fix compile error. Waiting for CI.

@ghost ghost changed the title Typos [WIP] Typos Sep 5, 2016
@ghost ghost changed the title [WIP] Typos Typos Sep 5, 2016
@RodneyBaker
Copy link
Collaborator

I'm posting this here as it is a Typo topic that is still open.

I"m not sure if this one is a problem or not but I happened upon the word 'zerary' which is the toonz word for 'geometric' and my curiosity got the best of me so I dug deeper. I saw that notes in the code state that word isn't used often because no one understands it's meaning. But that word isn't the (potential) problem word I want to bring to attention. Another word, 'zeray' (note the missing second 'r') got my attention mostly because it appears to be used in only one instance of code (although four times in that code).

It can be found here:
https://github.com/opentoonz/opentoonz/blob/1131f1c4e12011edf025cd82e3e1f2bb249e2f45/toonz/sources/toonzqt/fxdata.cpp

As it appears to be internally consistent it may not currently be producing a bug but if it is meant to be 'zerary' instead of 'zeray' then I assume it should be flagged as a typo.

I suspect this is a potential bug producer because unlike 'zerayfx' there are many instances of 'zeraryfx'.

Perhaps the word zeray is correct.
Perhaps not.

@shun-iwasawa
Copy link
Member

@RodneyBaker
Thank you for pointing the other typo. The term "zerary fx" is a quite unique term in Toonz's source. I think it is used as one of "arity" and it means "fx with no input port" (i.e. zero + ary = zerary) , under the following rule:

  • Fx with two input ports is called "binary fx".
  • Fx with one input port is called "unary fx".
  • And fx with no input port is called "zerary fx".
    (Usually the term "nullary" seems to be employed for such case... But zerary is OK for me.)

So, IMO "zerary" is correct and "zeray" would be typo.

@RodneyBaker
Copy link
Collaborator

Thanks @shun-iwasawa. That's great information.
I had a feeling that term was specifying some deeper information.
I was equating the first part with zero but... couldn't grasp that latter part.
I'm learning a ton of information from you guys/gals!

My favorite word (as of this moment) is 'zerary'. :)

@ideasman42 ideasman42 merged commit 17ede67 into opentoonz:master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: lenght
4 participants