Permalink
Commits on Sep 26, 2016
  1. Remove check that's done in a subroutine

    bhs committed Sep 14, 2016
Commits on Sep 13, 2016
  1. Adjust to delinted names

    bhs committed Sep 13, 2016
Commits on Jul 26, 2016
  1. Update per recent OT-go PRs

    bhs committed Jul 25, 2016
Commits on Jul 6, 2016
  1. Allocate SpanContext to deal with lifetime issues

    bhs committed Jul 6, 2016
  2. Fix comment indenting

    bhs committed Jul 6, 2016
Commits on Jul 3, 2016
  1. Illustrate the ramifications of ot.SpanContext

    bhs committed Jun 10, 2016
    Benchmark diffs:
    
    ```
    bhs@bhs-personal:~/git/lightstep/go/src$ ../bin/benchcmp /tmp/before /tmp/after
    benchmark                                                    old ns/op     new ns/op     delta
    BenchmarkSpan_Empty-8                                        629           632           +0.48%
    BenchmarkSpan_100Events-8                                    35847         35271         -1.61%
    BenchmarkSpan_1000Events-8                                   35587         35173         -1.16%
    BenchmarkSpan_100Tags-8                                      43618         44145         +1.21%
    BenchmarkSpan_1000Tags-8                                     44063         43838         -0.51%
    BenchmarkSpan_100BaggageItems-8                              145397        32579         -77.59%
    BenchmarkTrimmedSpan_100Events_100Tags_100BaggageItems-8     168957        79144         -53.16%
    BenchmarkInject_TextMap_Empty-8                              2221          2292          +3.20%
    BenchmarkInject_TextMap_100BaggageItems-8                    85977         87857         +2.19%
    BenchmarkInject_Binary_Empty-8                               388           390           +0.52%
    BenchmarkInject_Binary_100BaggageItems-8                     17861         18968         +6.20%
    BenchmarkJoin_TextMap_Empty-8                                2849          2872          +0.81%
    BenchmarkJoin_TextMap_100BaggageItems-8                      148235        146900        -0.90%
    BenchmarkJoin_Binary_Empty-8                                 1175          1231          +4.77%
    BenchmarkJoin_Binary_100BaggageItems-8                       37424         37700         +0.74%
    ```
    
    I made these changes pretty casually and wonder if the huge improvements
    on the BaggageItems benchmarks are due to some sort of measurement error
    in the test itself (i.e., an invalid result).
Commits on Mar 21, 2016
  1. Follow suit with the latest OT-go revisions

    bhs committed Mar 21, 2016
Commits on Mar 20, 2016
  1. Adapt to interface proposals in opentracing-go

    bhs committed Mar 19, 2016
    Here is benchmark data vs master:
    
    ```
    benchmark                                                    old ns/op     new ns/op     delta
    BenchmarkSpan_Empty-8                                        450           449           -0.22%
    BenchmarkSpan_100Events-8                                    34384         34367         -0.05%
    BenchmarkSpan_1000Events-8                                   34812         34973         +0.46%
    BenchmarkSpan_100Tags-8                                      43703         42846         -1.96%
    BenchmarkSpan_1000Tags-8                                     43114         43155         +0.10%
    BenchmarkSpan_100BaggageItems-8                              142956        138515        -3.11%
    BenchmarkTrimmedSpan_100Events_100Tags_100BaggageItems-8     166500        161684        -2.89%
    BenchmarkInject_TextMap_Empty-8                              418           2157          +416.03%
    BenchmarkInject_TextMap_100BaggageItems-8                    18617         78072         +319.36%
    BenchmarkInject_Binary_Empty-8                               991           770           -22.30%
    BenchmarkInject_Binary_100BaggageItems-8                     41699         49336         +18.31%
    BenchmarkJoin_TextMap_Empty-8                                1280          2696          +110.63%
    BenchmarkJoin_TextMap_100BaggageItems-8                      50890         143159        +181.31%
    BenchmarkJoin_Binary_Empty-8                                 1223          1150          -5.97%
    BenchmarkJoin_Binary_100BaggageItems-8                       78066         78061         -0.01%
    
    benchmark                                     old allocs     new allocs     delta
    BenchmarkInject_TextMap_Empty-8               3              6              +100.00%
    BenchmarkInject_TextMap_100BaggageItems-8     103            206            +100.00%
    BenchmarkInject_Binary_Empty-8                11             9              -18.18%
    BenchmarkInject_Binary_100BaggageItems-8      411            409            -0.49%
    BenchmarkJoin_TextMap_Empty-8                 1              14             +1300.00%
    BenchmarkJoin_TextMap_100BaggageItems-8       12             424            +3433.33%
    BenchmarkJoin_Binary_Empty-8                  11             10             -9.09%
    BenchmarkJoin_Binary_100BaggageItems-8        619            618            -0.16%
    
    benchmark                                     old bytes     new bytes     delta
    BenchmarkSpan_100Tags-8                       10519         10520         +0.01%
    BenchmarkSpan_100BaggageItems-8               10502         10520         +0.17%
    BenchmarkInject_TextMap_Empty-8               33            378           +1045.45%
    BenchmarkInject_TextMap_100BaggageItems-8     3233          15666         +384.57%
    BenchmarkInject_Binary_Empty-8                296           147           -50.34%
    BenchmarkInject_Binary_100BaggageItems-8      3496          14667         +319.54%
    BenchmarkJoin_TextMap_Empty-8                 1             320           +31900.00%
    BenchmarkJoin_TextMap_100BaggageItems-8       10518         23594         +124.32%
    BenchmarkJoin_Binary_Empty-8                  168           184           +9.52%
    BenchmarkJoin_Binary_100BaggageItems-8        20793         20809         +0.08%
    ```
    
    Some of these regressions can be improved by using a map[string]string
    instead of an actual http.Header object as the "backend" for the
    TextMap. The binary protocol at master is not worth thinking too
    carefully about since it's not even using protobufs/etc. But these do
    demonstrate that the old API – while clunky – at least didn't have many
    moving parts (or allocations).
  2. Move to interface-based carriers

    bhs committed Mar 17, 2016
Commits on Mar 4, 2016
  1. Fix the build (per the Context change)

    bhs committed Mar 4, 2016
  2. Make SplitTextCarrier work with superset maps

    bhs committed Mar 4, 2016
    For example, passing Go's http.Header map into both TracerState and
    Baggage should work. Related to
    opentracing/opentracing.io#73 .
Commits on Feb 29, 2016
  1. Re-fix the propagation_ot propagators

    bhs committed Feb 29, 2016
  2. Be consistent about propagation method naming

    bhs committed Feb 28, 2016
    Renames the propagator methods to mimic Tracer.Inject() and
    Tracer.Join().
  3. Change basictracer-go per opentracing-go's PR#65

    bhs committed Feb 27, 2016
    See also opentracing/opentracing-go#65 . This
    reuses the propagators but cuts out the Injector() middleman since it's
    no longer part of the Tracer API.
    
    To be merged immediately after the main opentracing-go PR.
Commits on Feb 20, 2016
  1. add the Go-friendly MIT license

    bhs committed Feb 20, 2016
    We want a well-known, reasonable, permissive LICENSE from day one. The
    MIT license has strong traction within the Go community and is thus
    unlikely to cause hiccups as a new dependency for an existing Go
    project/package.
Commits on Feb 13, 2016
  1. more tweaks

    bhs committed Feb 13, 2016
Commits on Feb 12, 2016
  1. fix the test

    bhs committed Feb 12, 2016
  2. deadcode removal

    bhs committed Feb 12, 2016
Commits on Feb 10, 2016
Commits on Jan 26, 2016
  1. cleanups and file renames

    bhs committed Jan 25, 2016
  2. better comments

    bhs committed Jan 24, 2016