Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Fix returned error for Inject #216

merged 1 commit into from Jul 4, 2019

Fix returned error for Inject #216

merged 1 commit into from Jul 4, 2019


Copy link

@moorara moorara commented Jun 25, 2019

I think when the passed SpanContext is not type of MockSpanContext, the error should be ErrInvalidSpanContext and not the ErrInvalidCarrier

Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@659c906). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #216   +/-   ##
  Coverage          ?   59.32%           
  Files             ?       14           
  Lines             ?      831           
  Branches          ?        0           
  Hits              ?      493           
  Misses            ?      298           
  Partials          ?       40
Impacted Files Coverage Δ
mocktracer/mocktracer.go 95.83% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659c906...5e5055e. Read the comment docs.

@yurishkuro yurishkuro merged commit 135aa78 into opentracing:master Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants