Make MockTracer thread-safe #86

Merged
merged 4 commits into from Jul 1, 2016

Projects

None yet

2 participants

@yurishkuro
Contributor

If people want to use MockTracer to test instrumentation of RPC frameworks, it needs to be thread-safe.

cc @bensigelman

yurishkuro added some commits Jun 30, 2016
@yurishkuro yurishkuro Make MockTracer thread-safe b58d06e
@yurishkuro yurishkuro Combine targets into a single 'lint' target
410952e
@yurishkuro yurishkuro Fix travis command
d912618
@yurishkuro yurishkuro Add tests
b8840d2
@yurishkuro
Contributor

@bensigelman now with tests and full coverage

@bensigelman bensigelman commented on the diff Jul 1, 2016
.PHONY: test
test:
go test -v -cover ./...
-.PHONY: fmt
-fmt:
- go fmt ./...
+cover:
@bensigelman
bensigelman Jul 1, 2016 Contributor

thank you!

@bensigelman
Contributor

Looks great. Thanks again. 🚢

@yurishkuro yurishkuro merged commit 485e089 into master Jul 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment