Add test coverage to the build #48

Merged
merged 2 commits into from Aug 22, 2016

Projects

None yet

4 participants

@yurishkuro
Contributor

No description provided.

@yurishkuro yurishkuro Add test coverage to the build
5b81f82
@bensigelman
Contributor

SGTM/LGTM. @bcronin should have a quick look (mainly about specific tools).

@bcronin
Collaborator
bcronin commented Aug 22, 2016

This looks good, thanks Yuri!

(One aside: I assume that because the code is "down compiled" from ES6 to ES5, the code coverage numbers won't be as accurate as one would hope, as presumably it's run against the generated code. I've only used istanbul briefly, but my last encounter with it was that it doesn't back-map to the original ES6 well. I'd be thrilled to discover I'm wrong about this, since this was something I struggled with a while back. If you know anything about this, I'd be interested to hear it.)

@yurishkuro
Contributor

As far as I can tell it checks coverage on the generated ES5 code. Which is fine with me, it has lots of gaps:

----------------------------|----------|----------|----------|----------|----------------|
File                        |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------------------------|----------|----------|----------|----------|----------------|
 dist/                      |     66.5 |    42.46 |    77.33 |    60.14 |                |
  opentracing-node-debug.js |     66.5 |    42.46 |    77.33 |    60.14 |... 1,1082,1102 |
----------------------------|----------|----------|----------|----------|----------------|
All files                   |     66.5 |    42.46 |    77.33 |    60.14 |                |
----------------------------|----------|----------|----------|----------|----------------|

My plan is to implement a test harness for the API similar to the one we have in Python, which will exercise all API methods and various parameter permutations.

@yurishkuro yurishkuro Add license link, use lcovonly default output
5b006b4
@yurishkuro
Contributor

Also, there's apparently an option to backport istambul coverage back to ES6: http://dev.topheman.com/es6-code-coverage-with-babel-plugin/

@coveralls

Coverage Status

Changes Unknown when pulling 5b006b4 on coveralls into * on master*.

@yurishkuro
Contributor

booked #49 to port coverage to ES6, if we get around to it

@yurishkuro yurishkuro merged commit 4e1001f into master Aug 22, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 60.14%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment