From ab1af163e20e377bec4cf684f98161fd40018d6f Mon Sep 17 00:00:00 2001 From: Ben Sigelman Date: Thu, 22 Sep 2016 12:17:02 -0700 Subject: [PATCH 1/2] Add a better default log() impl Since this is a deprecated method, the main task should be to translate to log_kv rather than blindly pass through. --- opentracing/span.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/opentracing/span.py b/opentracing/span.py index d9dc39d..af7dd0b 100644 --- a/opentracing/span.py +++ b/opentracing/span.py @@ -217,4 +217,12 @@ def log_event(self, event, payload=None): def log(self, **kwargs): """DEPRECATED""" - return self.log_kv(kwargs) + key_values = {} + if kwargs["event"] is not None: + key_values["event"] = kwargs["event"] + if kwargs["payload"] is not None: + key_values["payload"] = kwargs["payload"] + timestamp = None + if kwargs["timestamp"] is not None: + timestamp = kwargs["timestamp"] + return self.log_kv(key_values, timestamp) From 2614cef998b3cc0c6f68f6bc19ec8a65303c4788 Mon Sep 17 00:00:00 2001 From: Ben Sigelman Date: Thu, 22 Sep 2016 13:03:58 -0700 Subject: [PATCH 2/2] Delint --- opentracing/span.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/opentracing/span.py b/opentracing/span.py index af7dd0b..6a973ce 100644 --- a/opentracing/span.py +++ b/opentracing/span.py @@ -218,11 +218,11 @@ def log_event(self, event, payload=None): def log(self, **kwargs): """DEPRECATED""" key_values = {} - if kwargs["event"] is not None: - key_values["event"] = kwargs["event"] - if kwargs["payload"] is not None: - key_values["payload"] = kwargs["payload"] + if kwargs['event'] is not None: + key_values['event'] = kwargs['event'] + if kwargs['payload'] is not None: + key_values['payload'] = kwargs['payload'] timestamp = None - if kwargs["timestamp"] is not None: - timestamp = kwargs["timestamp"] + if kwargs['timestamp'] is not None: + timestamp = kwargs['timestamp'] return self.log_kv(key_values, timestamp)