New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to expose alerts with effective dates in the future #2351

Open
fpurcell opened this Issue Oct 7, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@fpurcell
Member

fpurcell commented Oct 7, 2016

We have alerts in our GTFSrt feed with effective dates happening in the future. In fact, we have a includeFuture=true param (ala http://trimet.org/transweb/ws/V1/FeedSpecAlerts/includeFuture/true) that exposes all alerts current and upcoming service alerts. We'd like to (continue to) show those alerts in our trip itineraries, and not have them filtered by the OTP API. But the 1.0.0 API is filtering out any alert with an effective date happening in the future. NOTE: the behavior of the 0.10.x code we're currently using was to show any and all alerts, regardless of effective date.

Thus we're requesting some config parameter that will stop the API from filtering on effective date.

One idea: a config parameter with a numerical value representing minutes to look ahead when filtering the alerts that come back via an itinerary (say 'alertsEffectiveDateOffset':29999). The alert offset will then only filter those alert effective dates that happen beyond system-time + offset.

p.s., https://basecamp.com/2327625/projects/7113183/messages/60863662#comment_446601581

@fpurcell fpurcell added this to the 1.1.0 milestone Oct 7, 2016

@demory demory self-assigned this Nov 3, 2016

demory added a commit that referenced this issue Nov 16, 2016

@abyrd abyrd removed the api label Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment