Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Stop clusters based on parent stations #2364
here in Greater Oslo, our stop hierarchy is 100% based on parent/child stops, for all transport modes. The parent stations are the ones that are exposed in our stop/place/address lookup module, while itineraries are presented on the "child stop"/stop point level. To achieve this, we have until now been using a mapping table in our integration platform. To mitigate the dependency on modules outside OTP, we have recently started looking at stop clusters, which seem to have been aimed at serving the purpose of mapping between child and parent.
However, it seems to me that today's implementation is only halfway there. The clustering is based on proximity instead of parent/child relation, and the cluster indexing is done during the generation. From the code comments, I understand that this is done because of insufficient parent station data in some cities, and the proximity-based clustering is done as a best effort (?)
What is the current view about this? I have rewritten the clusterStops() method to do the clustering based on parent/child, which seems to pretty much solve our requirements. Would it be possible to have both options available in the code base?