/OpenTripPlanner

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraphQL to latest version and add / improve support for passed arguments #2367

Closed
johannilsson opened this Issue Nov 14, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@johannilsson @barslett @andreyz @hannesj
@johannilsson
Contributor

johannilsson commented Nov 14, 2016

Arguments sent to the GraphQL endpoint is sent as a string from GraphiQL and needs to be deserialized before they're passed to the GraphQL library. Other GraphQL implementations also seems to handle this case.

The GraphQL version OTP is currently on does not work with complex types sent as arguments, this has been fixed in newer versions of the library.

johannilsson added a commit to johannilsson/OpenTripPlanner that referenced this issue Nov 14, 2016

@johannilsson
Update GraphQL to latest version and improve support for arguments 
* Update GraphQL library to latest stable version (2.2.0)
* Add support for parsing arguments if they're sent as a string
* Add support for operationName to the graphql endpoint
* Fix issue with findClosestStopsByWalking where the routing context must be set after batch

Fix opentripplanner#2367
60faa02

@johannilsson johannilsson referenced this issue Nov 14, 2016

Merged

Update GraphQL to latest version and improve support for arguments #2368

@hannesj hannesj referenced this issue Nov 14, 2016

Merged

Update GraphQL to latest version and improve support for arguments #102

johannilsson added a commit to johannilsson/OpenTripPlanner that referenced this issue Nov 22, 2016

@johannilsson
Change to handle variables sent as an empty string to graphql endpoint 
Fix opentripplanner#2367
efd08b3
@barslett

This comment has been minimized.

Sign in to view
Contributor

barslett commented Dec 19, 2016

Does anyone of you guys @johannilsson or @hannesj know anything about GraphiQL (https://github.com/graphql/graphiql). One of our developers looked at it, and it could make it easier to develop against GraphQL.
@andreyz

This comment has been minimized.

Sign in to view
Contributor

andreyz commented Dec 19, 2016

@barslett you might even like a native wrapper around it https://github.com/skevy/graphiql-app.

More great GraphQL resources here https://github.com/chentsulin/awesome-graphql
@hannesj

This comment has been minimized.

Sign in to view
Contributor

hannesj commented Dec 19, 2016

@barslett We are using it at http://dev.hsl.fi/graphql/console/

Also the locally installable version for development.

@abyrd abyrd closed this in #2368 Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment