Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM Tag Combination "highway=living_street" and "bicycle=designated" prevent Drive routing. #2374

Closed
robludwig opened this issue Dec 6, 2016 · 3 comments
Labels
Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days.

Comments

@robludwig
Copy link
Contributor

As mentioned in the Google Group I had a problem routing Drive Only trips on an OSM street tagged "living_street" in the Palo Alto area (steps to reproduce are in the linked thread).

I found that the specific combination of tags "highway=living_street" and "bicycle=designated" made the edge bike/walk only. Thanks to input from Nawak Khurshid, I found that I could edit DefaultWayPropertySource to add an entry for that specific combination:
setProperties(props, "highway=living_street;bicycle=designated", StreetTraversalPermission.BICYCLE_AND_CAR, 2, 2); and routing worked.

I know car routing is not a priority of the project, but is this the preferred way to make this edit or is there a better place to put the change that I'm not seeing?

@abyrd
Copy link
Member

abyrd commented Dec 7, 2016

Hi @robludwig, that file is indeed the right place to derive permissions from OSM tags. Adding a rule for a really specific set of tags, as you have done, fixes the problem. But the root of the problem may be the more general rule here:
https://github.com/opentripplanner/OpenTripPlanner/blob/master/src/main/java/org/opentripplanner/graph_builder/module/osm/DefaultWayPropertySetSource.java#L343

/* bicycle=designated, but no bike infrastructure is present */
        setProperties(props, "highway=*;bicycle=designated",
                StreetTraversalPermission.PEDESTRIAN_AND_BICYCLE, 0.97, 0.97);

This makes all roads with bicycle=designated default to pedestrian and bicycle only (no car), then adds permissions for all other modes for specific highway=* types in subsequent rules. Perhaps the general rule for highway=* should also use StreetTraversalPermission.ALL.

robludwig added a commit to robludwig/OpenTripPlanner that referenced this issue Dec 7, 2016
novalis added a commit that referenced this issue Dec 30, 2016
Re #2374. Allow Cars on highway=*;bicycle=designated
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days. label Jun 28, 2022
@leonardehrenfried
Copy link
Member

Since the PR fixing this was merged, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days.
Projects
None yet
Development

No branches or pull requests

3 participants