OSM Tag Combination "highway=living_street" and "bicycle=designated" prevent Drive routing.

[robludwig]

As mentioned in the Google Group I had a problem routing Drive Only trips on an OSM street tagged "living_street" in the Palo Alto area (steps to reproduce are in the linked thread).

I found that the specific combination of tags "highway=living_street" and "bicycle=designated" made the edge bike/walk only. Thanks to input from Nawak Khurshid, I found that I could edit DefaultWayPropertySource to add an entry for that specific combination:
setProperties(props, "highway=living_street;bicycle=designated", StreetTraversalPermission.BICYCLE_AND_CAR, 2, 2); and routing worked.

I know car routing is not a priority of the project, but is this the preferred way to make this edit or is there a better place to put the change that I'm not seeing?

[abyrd]

Hi @robludwig, that file is indeed the right place to derive permissions from OSM tags. Adding a rule for a really specific set of tags, as you have done, fixes the problem. But the root of the problem may be the more general rule here:
https://github.com/opentripplanner/OpenTripPlanner/blob/master/src/main/java/org/opentripplanner/graph_builder/module/osm/DefaultWayPropertySetSource.java#L343

/* bicycle=designated, but no bike infrastructure is present */
        setProperties(props, "highway=*;bicycle=designated",
                StreetTraversalPermission.PEDESTRIAN_AND_BICYCLE, 0.97, 0.97);

This makes all roads with bicycle=designated default to pedestrian and bicycle only (no car), then adds permissions for all other modes for specific highway=* types in subsequent rules. Perhaps the general rule for highway=* should also use StreetTraversalPermission.ALL.