Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bikes_allowed handling #3359

Closed
flaktack opened this issue Mar 2, 2021 · 0 comments · Fixed by #3360
Closed

Simplify bikes_allowed handling #3359

flaktack opened this issue Mar 2, 2021 · 0 comments · Fixed by #3360
Milestone

Comments

@flaktack
Copy link
Contributor

flaktack commented Mar 2, 2021

Bike access handling in OTP2 could use a few simplifications:

  • the internal models for Trip and Route have two fields for bike access due to differing GTFS fields (Trip, Route, BikeAccess)
  • a default bikesAllowed values may be specified in GtfsBundle (which has a default of allowed), but its value may not be set from the JSON configuration (GtfsModule, GtfsBundle).

To simplify things:

  • the mapping of GTFS trips.txt:bikes_allowed, trips.txt:trip_bikes_allowed, routes.txt:bikes_allowed and routes.txt:route_bikes_allowed can be handled when converting to the internal model
  • Update Trip and Route to only have a single BikeAccess bikesAllowed field
  • setting a default bikesAllowed value for Trips if none is provided could be removed
@t2gran t2gran added this to Issues backlog in OTP2 Development via automation Mar 3, 2021
@t2gran t2gran added this to the 2.1 milestone Mar 3, 2021
OTP2 Development automation moved this from Issues backlog to Done Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants