Fix bugs in park and ride search#2424
Merged
novalis merged 4 commits intoMay 14, 2017
Merged
Conversation
When finding the closest vertex to the destination for park and ride , the traverse mode must be 'walk' and not 'car'.
fredinge
changed the title
novalis
reviewed
May 1, 2017
| if (modes.getCar()) | ||
| nonTransitMode = TraverseMode.CAR; | ||
| // for park and ride we will start in car mode and walk to the end vertex | ||
| if(endVertex && (options.parkAndRide || options.kissAndRide)){ |
Contributor
There was a problem hiding this comment.
nit: please correct the formatting on this line (and the else) to match the rest of OTP.
Contributor
|
Can you provide a test for this? |
Contributor
Author
|
Added some unit tests and corrected formatting. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #2421
When finding the closest vertex to the destination for park
and ride , the traverse mode must be 'walk' and not 'car'.