Platform entries linking - #2428
Merged
novalis merged 4 commits intoJun 28, 2017
Merged
Conversation
novalis
reviewed
May 1, 2017
| double[] testPointInside = { 59.8926474, 10.524729}; | ||
| double[] testPointOutside = { 59.8925344, 10.5249007}; | ||
|
|
||
| assert(PlatformLinker.contains(platform, testPointInside)); |
Contributor
There was a problem hiding this comment.
nit: I would prefer to use the junit assertion functions.
novalis
reviewed
May 1, 2017
| Vertex in = gv; | ||
| if (!(e instanceof StreetEdge || e instanceof StreetTransitLink || | ||
| e instanceof ElevatorEdge || e instanceof FreeEdge)) { | ||
| e instanceof ElevatorEdge || e instanceof FreeEdge || e instanceof PathwayEdge)) { |
Contributor
There was a problem hiding this comment.
This commit adds this but the next one removes it. Which do you really want?
novalis
reviewed
May 1, 2017
| private void linkPlatformEntries() { | ||
| PlatformLinker platformLinker = new PlatformLinker(graph, osmdb); | ||
| platformLinker.linkEntriesToPlatforms(); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: remove this blank line
Contributor
|
Can you provide an integration test here? |
Contributor
Author
|
Added integration test |
Contributor
|
@novalis Building seems to have failed due to travis - not the code itself. Could you kick it off again? |
Contributor
|
I think you'll need to rebase -- IIRC, that error was fixed later on in master. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a solution for #2422.
It links the entries inside the platform area to the platform by creating new edges between the entry's end vertex and the vertices in the ring defining the platform area. OTP will then be able to do routing through the platforms fairly accurate. The feature can be enabled in the build config file.