Skip to content

Don't attempt to decrypt keys on PRs; it'll just make the build fail - #2441

Merged
novalis merged 1 commit into
opentripplanner:masterfrom
novalis:travis-prs
May 14, 2017
Merged

Don't attempt to decrypt keys on PRs; it'll just make the build fail#2441
novalis merged 1 commit into
opentripplanner:masterfrom
novalis:travis-prs

Conversation

@novalis

@novalis novalis commented May 12, 2017

Copy link
Copy Markdown
Contributor

Please don't merge unless travis succeeds.

@barbeau

barbeau commented May 12, 2017

Copy link
Copy Markdown
Contributor

I just fixed this issue in a Conveyal repo - this should do the trick:
conveyal/gtfs-lib@476e17b

@novalis

novalis commented May 14, 2017

Copy link
Copy Markdown
Contributor Author

Thanks Sean.

@novalis
novalis merged commit 2b2b021 into opentripplanner:master May 14, 2017
@novalis
novalis deleted the travis-prs branch May 14, 2017 05:22
@barbeau

barbeau commented May 30, 2017

Copy link
Copy Markdown
Contributor

@novalis It looks like PRs are still failing due to attempt to decrypting keys - see #2453. Failed Travis build at https://travis-ci.org/opentripplanner/OpenTripPlanner/builds/237508353?utm_source=github_status&utm_medium=notification.

cc @carvalhorr

@novalis

novalis commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

I think that PR just needs a rebase; it's probably still got the old travis.yml that pre-dates my fix.

@barbeau

barbeau commented May 30, 2017

Copy link
Copy Markdown
Contributor

@novalis Ah, sorry, you're right - that PR is based on the gbfs branch, which doesn't have your commit 2b2b021 that fixed the PR builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants