Skip to content

remove/update deprecated HTTPClient code, adding missing ciphers for SSL#2451

Merged
abyrd merged 1 commit into
masterfrom
fix-ssl
Mar 16, 2018
Merged

remove/update deprecated HTTPClient code, adding missing ciphers for SSL#2451
abyrd merged 1 commit into
masterfrom
fix-ssl

Conversation

@landonreed

@landonreed landonreed commented May 24, 2017

Copy link
Copy Markdown
Member

Replace deprecated DefaultHTTPClient with HttpClientBuilder.

Fixes #2450.

@landonreed landonreed requested a review from mattwigway May 24, 2017 19:11
@pailakka pailakka mentioned this pull request Dec 12, 2017
Merged
@demory demory self-requested a review January 9, 2018 16:45
@landonreed landonreed requested review from abyrd and removed request for mattwigway March 15, 2018 21:07
abyrd
abyrd approved these changes Mar 16, 2018
View reviewed changes

@abyrd abyrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abyrd abyrd merged commit a2ef285 into master Mar 16, 2018
@abyrd abyrd deleted the fix-ssl branch March 16, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abyrd abyrd abyrd approved these changes

@demory demory Awaiting requested review from demory

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@landonreed @abyrd