Remove Open Traffic prototype code

[drewda]

To be completed by pull request submitter:

• issue: closes Remove Open Traffic prototype code #2697
• roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
• tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
• formatting: Have you followed the suggested code style?

To be completed by @opentripplanner/plc:

• reviews and approvals by 2 members, ideally from different organizations
• before merging: add a bullet point to the changelog file with description and link to the linked issue
• after merging: update the relevant card on the roadmap

[drewda]

@opentripplanner/plc I believe I've removed all dangling references -- but would appreciate another set of eyes.

[abyrd]

Hi @drewda, I just reviewed these changes and they look good to me. I would agree that we should remove this outdated and unmaintained code, and these commits should do the job. We may want to retain some kind of mechanism for pluggable street speed sources, independent of the opentraffic-specific implementation. But that should be easy to add back in if and when it's needed.

[abyrd]

@t2gran and @gmellemstrand I tagged you on this PR because we'll need one more review, and you've generally been favorable to removing dead code and reducing complexity so you may be motivated to review this.

[t2gran]

I am in favor. I looked over the code changes and they looked straight forward.

[Patafix]

Hello,
What are the alternative to have traffic on OTP after the 1.4.0

My team use this feature a lot.

Thanks

[abyrd]

Hi @Patafix, the version of OpenTraffic included in OTP was a prototype that was never maintained and development moved on to a completely different format. We were planning to remove the code entirely. If you need it, you would need to create a branch and revert these commits.

Is it the OpenTraffic data format you're using or just the idea of adding speed data to OTP? It should be straightforward to create your own system like StreetSpeedSource.

[Patafix]

Thanks for you reply @abyrd we can use any format we want.