Skip to content

Add FinlandWayPropertySetSource - #3096

Merged
hannesj merged 3 commits into
opentripplanner:dev-2.xfrom
CGI-Move:finland-way-property-set-source
Jun 16, 2020
Merged

hannesj merged 3 commits into
opentripplanner:dev-2.xfrom
CGI-Move:finland-way-property-set-source

Conversation

@hannesj

@hannesj hannesj commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Copy over the changes from the HSLDevcom fork as a separate WayPropertySetSource.

To be completed by pull request submitter:

  • issue: Link to or create an issue that describes the relevant feature or bug. Add GitHub keywords to this PR's description (e.g., closes #45).
  • roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
  • tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
  • formatting: Have you followed the suggested code style?
  • documentation: If you are adding a new configuration option, have you added an explanation to the configuration documentation tables and sections?
  • changelog: add a bullet point to the changelog file with description and link to the linked issue

To be completed by @opentripplanner/plc:

  • reviews and approvals by 2 members, ideally from different organizations
  • after merging: update the relevant card on the roadmap

@hannesj
hannesj requested a review from a team June 9, 2020 11:18
optionsome
optionsome previously approved these changes Jun 11, 2020

@optionsome optionsome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that all changes made in hsldevcom fork to DefaultWayPropertySetSource and everything from FinlandWayPropertySetSource are included in this PR.

@t2gran t2gran added the OTP2 label Jun 11, 2020
@hannesj
hannesj merged commit 9a313d7 into opentripplanner:dev-2.x Jun 16, 2020
@hannesj
hannesj deleted the finland-way-property-set-source branch June 16, 2020 08:35
tvainika added a commit to CGI-Move/OpenTripPlanner that referenced this pull request Sep 24, 2020
@tvainika tvainika mentioned this pull request Sep 24, 2020
8 tasks
@abyrd abyrd added this to the 2.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants