Repository navigation
Move debug timing to RoutingWorker and adapt to OTP2 routing phases - #3109
Merged
Merged
Conversation
hannesj
force-pushed
the
debug-output
branch
2 times, most recently
from
June 23, 2020 07:43
2a5a93c to
8c1e665
Compare
t2gran
requested changes
Jun 25, 2020
Member
There was a problem hiding this comment.
My main comment here is that the DebugOutput plays two roles and should be split into a plan DTO
located in the org.opentripplanner.api.resource and a sevice witch do the timing and aggregates the results , and in the end produces the DTO. Maybe DebugAggregatoris an ok name for the service in lack of a better one. I would put it in the org.opentripplanner.routing.framework package. I could not find an existing good candidate.
If we do so, we get one LOGGER we can turn on/off for perfomance logging and the concerns are separated.
t2gran
previously approved these changes
Jul 30, 2020
t2gran
left a comment
Member
There was a problem hiding this comment.
This looks as a good start. JavaDoc on some public classes is missing.
added 2 commits
August 4, 2020 14:19
t2gran
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes DebugOutput use the new routing phases in OTP2, and updates their calculation. Previously a time of 0ms was reported for everything, as the DebugOutput object was not used in the routing worker.
To be completed by pull request submitter:
closes #45).To be completed by @opentripplanner/plc: