Remove AlertPatcher - #3134
Merged
Merged
Conversation
added 8 commits
July 6, 2020 14:58
As there are no sensitive services anymore
And documentation to scripting and analyst, which were using it
hannesj
force-pushed
the
remove-alert-patcher
branch
from
July 8, 2020 11:59
d92c000 to
13178d3
Compare
t2gran
self-requested a review
August 6, 2020 09:36
added 2 commits
August 6, 2020 19:33
t2gran
previously requested changes
Aug 26, 2020
t2gran
left a comment
Member
There was a problem hiding this comment.
I general I think this looks good, and I am in favor of merging this and then fix any problems if any. @gmellemstrand or @lassetyr could make the approval after coordinating on reviewing the Siri updaters and testing it. At Entur we should patch the Transmodel API as soon as possible after the merge, since this is blocking us from merging it into our OTP2 production branch.
Comment on lines
+6
to
11
| import org.opentripplanner.routing.alertpatch.AlertUrl; | ||
| import org.opentripplanner.routing.alertpatch.EntitySelector; | ||
| import org.opentripplanner.routing.alertpatch.StopCondition; | ||
| import org.opentripplanner.routing.alertpatch.TimePeriod; | ||
| import org.opentripplanner.routing.alertpatch.TransitAlert; | ||
| import org.opentripplanner.routing.core.TraverseMode; |
Member
There was a problem hiding this comment.
@lassetyr Would you mind to review this part? The changes to the Siri updaters.
Contributor
There was a problem hiding this comment.
Looks good, I am also in favor of merging.
hannesj
force-pushed
the
remove-alert-patcher
branch
from
August 27, 2020 07:26
cf82a60 to
9b796fb
Compare
…into remove-alert-patcher
hannesj
force-pushed
the
remove-alert-patcher
branch
from
August 27, 2020 07:28
9b796fb to
7402dae
Compare
lassetyr
added a commit
to entur/OpenTripPlanner-LegacyHSLFork
that referenced
this pull request
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some todos left in the SIRI-SX updater, as well as tests.
To be completed by pull request submitter:
To be completed by @opentripplanner/plc: