Do not overwrite TripPattern ids

[hannesj]

Do not overwrite id on TripPattern, but rather leave the generated id as is. This will fix the issue below, as there are no longer collisions in fetching Timetables for TripPatterns, as the hash and equals are based on the id.

Also fix a bug in date comparison when removing old data.

To be completed by pull request submitter:

• issue: ArrayIndexOutOfBoundsException when applying trip updates #3110
• roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
• tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
• formatting: Have you followed the suggested code style?
• documentation: If you are adding a new configuration option, have you added an explanation to the configuration documentation tables and sections?
• changelog: add a bullet point to the changelog file with description and link to the linked issue

To be completed by @opentripplanner/plc:

• reviews and approvals by 2 members, ideally from different organizations
• after merging: update the relevant card on the roadmap

[t2gran]

This looks ok.

[hannesj]

@sven4all Can you test if this works now?

[sven4all]

I tested it and it seems to work for me as well.