bugfix: NPE when generating TripPatterns in TripPatternCache - #3284
Merged
Conversation
t2gran
added
!Bug
gmellemstrand
previously approved these changes
Dec 8, 2020
gmellemstrand
left a comment
gmellemstrand
left a comment
Contributor
There was a problem hiding this comment.
I have tested this with the Netherlands data and GTFS-RT feed, and it seems to work correctly.
abyrd
reviewed
Dec 15, 2020
abyrd
left a comment
abyrd
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but I would recommend the method name change @gmellemstrand mentioned.
abyrd
approved these changes
Dec 15, 2020
This was referenced Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a RealTime update do not match an existing TripPattern a new one is generated, but there is a NullPointerException in when the new id is generated.
To fix this, the internal model is also cleaned up a bit, by making the
directionIda numeric field, not a string. GTFS uses 0 and 1, while Netex have 1,2,3 and 4 legal values.To be completed by pull request submitter:
To be completed by @opentripplanner/plc: