German way property set and improvements to bicycle routes

[leonardehrenfried]

Summary

This PR improves the cycling algorithm by making the following improvements:

• it applies the tags lcn, rcn, ncn from OSM cycling network relations to the relation's members
• since ways can be on all of these networks at the same time a logical OR matcher was introduced for the way property sets
• a German way property set was introduced that fine-tunes the routing for Germany but also takes advantage of the above code
• a more realistic turn cost model for bicycles that avoids left turns
• makes the car speed parsing more robust and allow single digit speeds

Issue

closes #3397
closes #3398
closes #3402

Unit tests

There are a tests covering the way property set and the logical OR.

I've also added a new test for applying the bike route relation tags to the ways.

Code style

✅

Documentation

I've added the way property set to the documentation and updated the documentation about how to prepare OSM data to include bicycle routes.

Changelog

✅

[optionsome]

Haven't taken a deep look at this but is "a more realistic turn cost model for bicycles that avoids left turns" still a valid concern in countries that use left-hand traffic?

[leonardehrenfried]

This exact question came up in the dev meeting and I will make it respect left hand traffic.

[flaktack]

RoutingRequest also contains a field for the driving direction (driveOnRight), which is used by calculateTurnAngle(). The code here seems to work independently of that.

[leonardehrenfried]

Well spotted!

Am I reading it correctly that when you set the driving direction then to left hand side, then a left turn is magically turned into a right hand one? If this is the case then I don't need change anything.

[leonardehrenfried]

Ok, after a bit of investigation, this does exactly what we need. I've added tests to verify.

[leonardehrenfried]

It turns out that left/hand right hand traffic was already taken into account however the method and variable names made it hard to find out. I've added tests to make sure that it really is the case.

I've also incorporated @abyrd's feedback.

[leonardehrenfried]

@abyrd I've removed the the request parameter driveOnRight and replaced it with an enum derived from the way property sets. I've also refactored the code that deals with left/right turns, removed the magic and made it generally more clear what is happening.

I've caught more cases where someone uses logical ORs with an unsupported combination and an exception is thrown.

@t2gran @abyrd @optionsome @gmellemstrand Since the improvements of the bicycle routing rests mainly on adding the mixin for lcn/rcn/ncn ways, should I add this to the default way property set?

[leonardehrenfried]

I've just taken on the feedback from today's meeting and the formatting feedback by @t2gran.

I think this is good for another round of reviews.

[leonardehrenfried]

Unless there are more review comments, I think this one is ready to merge, isn't it?