Add bike rental vs walking filter#3446
Merged
gmellemstrand merged 6 commits intoMay 4, 2021
Merged
Conversation
added 2 commits
April 30, 2021 11:10
leonardehrenfried
previously approved these changes
May 4, 2021
leonardehrenfried
previously approved these changes
May 4, 2021
leonardehrenfried
approved these changes
May 4, 2021
Member
|
This is becoming a bit of a cat-and-mouse game! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new filter for bike rental itineraries, which filters out itineraries that contain a lot of walking compared to actual bike rental. A value for the ratio of distance that has to consist of bike rental compared to the total distance of the Itinerary is specified. The default is 0.3, which means that at least 30% of the total distance has to be covered on a rented bike.
Issue
Closes #3445
Unit tests
RemoveBikeRentalWithMostlyWalkingTesthas been addedDocumentation
Javadoc added
Changelog
Changelog entry added