Repository navigation
Import GTFS-Flex v2 Flexible trips - #3453
Merged
Merged
Conversation
Member
|
We have tested this patch and it indeed does import our GTFS Flex trips successfully. Therefore I recommend this to be merged. However, we're still in the process of tracking down some awful performance when actually using the flex routing algorithm. Once we have completed the investigation we can provide more feedback. |
leonardehrenfried
previously approved these changes
May 4, 2021
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I've left a question and a suggestion but in general, this can be merged.
t2gran
previously approved these changes
May 4, 2021
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
From an none-functional perspective this looks good.
…into gtfs-flex-v2-import
leonardehrenfried
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import GTFS-Flex v2 Flexible trips
Issue
closes #3452
Unit tests
No tests added
Code style
Have you followed the suggested code style? Yes
Documentation
Changelog
Was a bullet point added to the changelog file with description and link to the linked issue?