Add maxAccessEgressDurationSecondsForMode to RoutingRequest - #3560
Merged
gmellemstrand merged 5 commits intoAug 11, 2021
Conversation
gmellemstrand
added
Entur
leonardehrenfried
previously approved these changes
Jul 30, 2021
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
The code looks good but I was wondering if you could add an example of how to configure it in routingDefaults.
Member
|
Also the changelog is missing. |
added 2 commits
August 4, 2021 16:06
leonardehrenfried
previously approved these changes
Aug 11, 2021
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
leonardehrenfried
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows a maxAccessEgressDuration to be configured per mode. Some modes may be more resource intensive than others. As we have experienced, this especially
Issue
#3559
Unit tests
No new tests
Changelog
Was a bullet point added to the changelog file with description and link to the linked issue?