Skip to content

Add bicycle safety report browser - #3563

Merged
leonardehrenfried merged 7 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:bike-tags-documentation
Jul 20, 2021
Merged

Add bicycle safety report browser#3563
leonardehrenfried merged 7 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:bike-tags-documentation

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Jul 20, 2021

Copy link
Copy Markdown
Member

Summary

This adds a HTML and CSV reports to the report API that lets developer browse the multitude of rules for the bicycle safety factor.

Screenshot from 2021-07-20 10-00-53

It's basically a continually updated version of https://wiki.openstreetmap.org/wiki/OpenTripPlanner#Bicycle_routing.

A (static) version of this is available as a preview here: https://leonard.io/otp-bicycle-safety-report/

Issue

n/a

Unit tests

n/a

Code style

Documentation

The document about troubleshooting the routing has been substantially updated.

Changelog

@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner July 20, 2021 08:36
Comment thread docs/sandbox/ReportApi.md
@t2gran t2gran added this to the 2.1 milestone Jul 20, 2021
t2gran
t2gran previously approved these changes Jul 20, 2021

@t2gran t2gran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

  • Most of the changes outside the Sandbox is documentation - witch is great! The few other changes are "safe" and none intrusive.
  • I also approve changes within the Sandbox on behalf of Entur.

This is reddy to be merged.

@t2gran t2gran added the Entur Test This is currently being tested at Entur label Jul 20, 2021
@leonardehrenfried

Copy link
Copy Markdown
Member Author

I've made a few cosmetic changes and and fixed some typos. I'd be grateful for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur Test This is currently being tested at Entur

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants