Do not allow bicycle traversal on ways tagged with mtb:scale - #3578
Merged
gmellemstrand merged 5 commits intoAug 9, 2021
Merged
Conversation
| } | ||
|
|
||
| @Test | ||
| public void testMtbScalePedestrian() { |
Member
There was a problem hiding this comment.
I like this test but after having looked around the the OSM data in Norway, I found that the mtb:scale tag is also used in combination with highway=track.
Examples:
https://www.openstreetmap.org/way/514943207
https://www.openstreetmap.org/way/370993765
I think it'd be worthwhile to add a test for this, too, to prevent someone breaking it by accident.
leonardehrenfried
previously approved these changes
Aug 6, 2021
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I think this is a good change and support it. Other than the slightly more extensive testing, I like this PR a lot.
gmellemstrand
force-pushed
the
otp2_exclude_mtb_for_biking
branch
from
August 9, 2021 08:40
32b5b88 to
a33d5c4
Compare
leonardehrenfried
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restricts the traversal of
mtb:scaletagged ways:mtb:scale=0 - Pedestrian and bicycle
mtb:scale=1 - Pedestrian only
mtb:scale=2 - Pedestrian only
mtb:scale=3 - No traversal
mtb:scale=4 - No traversal
mtb:scale=5 - No traversal
mtb:scale=6 - No traversal
It also renames the
RoutingRequest.optimizefield tobicycleOptimizeTypeand sets the default toSAFEinstead ofQUICK.Also, the Transmodel API now reads the correct field when applying
bicycleOptimizeTypeto theRoutingRequest.Issue
No issue
Unit tests
Added new unit tests for the WayPropertySource
Changelog
Added changelog