Allow bicycles on ferries for Netex data

[leonardehrenfried]

Summary

When importing Netex data, always allow bicycles to be taken onto ferries. This is useful because in Norway ferries are an important transport mode but the operators don't provide data in the Netex feeds if you're allowed to take the bike on. With very few exceptions however, you're allowed to do so.

What does it look like in the debug UI?

Reading the information from Netex

It was not clear to me how the bicycle conveyance information is actually supposed to be extracted from Netex as the schema is quite complex.

I was able to find the following references:

• The standard mentions that bicycle conveyance is meant to be expressed as a type of luggage: https://github.com/NeTEx-CEN/NeTEx/blob/0436cb774778ae68a682c28e0a21013e4886c883/xsd/netex_part_3/part3_fares/netex_usageParameterLuggage_support.xsd#L120
• In the example provided by Entur there is also a reference to bicycle conveyance: https://github.com/entur/profile-examples/blob/7f45e036c870205102d96ef58c7ce5008f4edcf1/netex/fares-sales/Entur_PARTIAL_EXAMPLE_INCOMPLETE_FinnmarkFullExample.xml#L1598-L1611

However in the current Norway-wide feed I cannot find an example of FareFrame or LuggageAllowance.

Is there an expert that I can ask where to extract this information from?

Issue

n/a

Tests

A test has been added.

Code style

Yes.

Documentation

I've commented the code with lots of explanations.

Changelog

[leonardehrenfried]

As requested I have added a parameter to the netex config so that you can exclude certain line ids from allowing bicycles on.

This however meant that most code in this PR is about this config param and the actual logic is quite small.

[t2gran]

In general the implementation looks good,I have suggested a name change since I think the ferryWithoutBicycleIds is a bit confusing - bicycleIds or ferryIds.

[leonardehrenfried]

The name is indeed confusing - I will change it. Thanks!

[t2gran]

Looks good.

[leonardehrenfried]

I just rebuild the Norway graph tested again - it works.