Add new routing errors for cases where all itineraries were filtered by post-processing - #3628
Merged
Merged
Conversation
hannesj
force-pushed
the
otp2_improve_errors
branch
from
September 29, 2021 18:00
7a4b912 to
f605cdf
Compare
hannesj
force-pushed
the
otp2_improve_errors
branch
from
September 30, 2021 10:18
c3d7c0a to
7b4a886
Compare
hannesj
commented
Sep 30, 2021
hannesj
commented
Sep 30, 2021
hannesj
commented
Sep 30, 2021
hannesj
force-pushed
the
otp2_improve_errors
branch
from
September 30, 2021 18:15
7b4a886 to
fe24929
Compare
hannesj
commented
Oct 5, 2021
hannesj
commented
Oct 5, 2021
hannesj
force-pushed
the
otp2_improve_errors
branch
from
October 5, 2021 11:25
fe24929 to
a4a07bf
Compare
hannesj
force-pushed
the
otp2_improve_errors
branch
from
October 7, 2021 10:16
ac9abd9 to
152494d
Compare
hannesj
commented
Oct 7, 2021
hannesj
commented
Oct 7, 2021
hannesj
force-pushed
the
otp2_improve_errors
branch
2 times, most recently
from
October 8, 2021 09:38
17b79a1 to
02ad892
Compare
Member
|
Should we keep this as a "draft" until the filter chain is merged? |
This happens, when both the direct search and transit access/egress search adds routing errors
Co-authored-by: Thomas Gran <t2gran@gmail.com>
Locale is not injected in Transmodel API
Contributor
Author
|
Fixes #3672 |
Contributor
Author
|
Fixes #3676 |
t2gran
reviewed
Oct 29, 2021
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
previously approved these changes
Nov 2, 2021
flaktack
reviewed
Nov 4, 2021
flaktack
left a comment
flaktack
left a comment
Contributor
There was a problem hiding this comment.
I've tested this and all errors were returned as expected on the REST API, save for WALKING_BETTER_THAN_TRANSIT.
abyrd
previously approved these changes
Nov 4, 2021
flaktack
approved these changes
Nov 9, 2021
flaktack
left a comment
flaktack
left a comment
Contributor
There was a problem hiding this comment.
The errors are now uniformly present 🥳, thanks!
t2gran
approved these changes
Nov 9, 2021
abyrd
approved these changes
Nov 9, 2021
| Predicate<Vertex> isNotConnected = isFrom ^ opt.arriveBy | ||
| ? hasNoOutgoing | ||
| : hasNoIncoming; | ||
| Predicate<Vertex> isNotConnected = (isFrom == opt.arriveBy) ? hasNoIncoming : hasNoOutgoing; |
Member
There was a problem hiding this comment.
I love the readability of this simple substitution.
leonardehrenfried
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new errors describing why no itineraries were found and expose them through new field in Transmodel GraphQL API.
This also re-adds the routing errors which were lost in the migration from OTP1 to OTP2
Documentation
New descriptions were written for the GraphQL API.
Changelog
Was a bullet point added to the changelog file with description and link to the linked issue?