Check boarding and alighting permissions in TransferGenerator#3641
Merged
t2gran merged 4 commits intoOct 14, 2021
Conversation
hannesj
commented
Oct 12, 2021
t2gran
reviewed
Oct 12, 2021
t2gran
previously approved these changes
Oct 12, 2021
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
This is an important fix, and we have tested this and rolled it out in production.
abyrd
previously approved these changes
Oct 12, 2021
t2gran
approved these changes
Oct 13, 2021
Member
|
This had 2 approvals before the merging, so I will just force this trough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransferGenerator did not previously check for boarding/alighting permissions, if the transfer was at a single stop. This adds a check similar to how it was done, if a street transfer was necessary.
Issue
Fixes #3594
Unit tests
Added four unit tests for alighting/boarding restriction at same/different stop.
Documentation
None required
Changelog
Added