Add support for car and scooter rental modes

[hannesj]

Summary

Add support for specifying the rental vehicle form factor in the routing request. Previously only bike rental was supported, and using it would return itineraries with both scooter and car rentals.

Issue

Closes #3705

Unit tests

What should be tested?

Documentation

None needed?

[optionsome]

Is the "fix: Map transfer leg mode correctly" commit fixing an existing problem or one created within this pull request?

[optionsome]

There is a RoutingModes.md file that could in theory be updated here but as stated in the document, its future is a bit unclear.

[optionsome]

I tested this with oslo area osm and https://api.entur.io/mobility/v2/gbfs/limeoslo/gbfs scooter data. With the OTP client, I used /?module=planner&fromPlace=59.9193228937592%2C10.713558197021483&toPlace=59.91200869359693%2C10.77106475830078&time=3%3A50pm&date=11-09-2021&mode=SCOOTER_RENT&maxWalkDistance=4828.032&arriveBy=false&wheelchair=false&showIntermediateStops=true&debugItineraryFilter=false&locale=en query and changed between Depart/Arrive. Strangely with the Arrive option it added a second scooter leg at the end. Also the description of the SCOOTER leg is undefined (not sure if this is just some issue with this debug client) and icon is missing for scooter (not really an issue as this is just a debug client).

Also, we are not currently using scooter data in Finland with the legacy graphql API but these changes prevent finding trips using scooters if someone is (maybe @leonardehrenfried ?), as the SCOOTER type is not added to Mode enum in the schema.

[leonardehrenfried]

I tested this with a city where we have scooter and it works as expected.

Although it would probably be better if we defined a colour for the scooter leg in the debug client.

[hannesj]

Is the "fix: Map transfer leg mode correctly" commit fixing an existing problem or one created within this pull request?

This is an existing issue, which was fixed

[hannesj]

@optionsome @leonardehrenfried The issues with the debugging client, the last leg in arrive by searches and the legacy GraphQL API should be fixed now.

[optionsome]

Looks good to me