Skip to content

Do not parse pass-through information in GBFS mappers - #3709

Merged
hannesj merged 1 commit into
opentripplanner:dev-2.xfrom
entur:otp2_remove_unneeded_parsing
Nov 2, 2021
Merged

hannesj merged 1 commit into
opentripplanner:dev-2.xfrom
entur:otp2_remove_unneeded_parsing

Conversation

@hannesj

@hannesj hannesj commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

Summary

Remove parsing of data in GBFS mappers, which can be presented as strings to the user.

Issue

closes #3708

Unit tests

None updated

Documentation

None needed

@hannesj
hannesj requested a review from a team as a code owner November 1, 2021 11:26
@leonardehrenfried

leonardehrenfried commented Nov 1, 2021

Copy link
Copy Markdown
Member

I'm surprised that you didn't have to touch any of the API mapping code for this.

I guess these fields are simply never accessed and not exposed via any API, isn't it?

@hannesj

hannesj commented Nov 1, 2021

Copy link
Copy Markdown
Contributor Author

Yes. They are only read, but not yet exposed through any API

@hannesj hannesj added the Entur Test This is currently being tested at Entur label Nov 1, 2021
@t2gran t2gran added this to the 2.1 milestone Nov 2, 2021
@t2gran
t2gran self-requested a review November 2, 2021 16:01
@hannesj
hannesj merged commit c47f05c into opentripplanner:dev-2.x Nov 2, 2021
@hannesj
hannesj deleted the otp2_remove_unneeded_parsing branch November 2, 2021 16:02
t2gran pushed a commit that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur Test This is currently being tested at Entur

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors from parsing pass-throught data from GBFS are polluting the logs

3 participants