Logging first time instance reports it is ready to use - #3733
Merged
Conversation
lassetyr
added
!Improvement
t2gran
reviewed
Nov 10, 2021
A few code cleanup is applied as well.
t2gran
reviewed
Nov 11, 2021
lassetyr
commented
Nov 12, 2021
t2gran
force-pushed
the
otp2_log_readiness
branch
from
November 12, 2021 13:05
300f712 to
6391ef1
Compare
| private final OtpProjectInfo projectInfo = projectInfo(); | ||
|
|
||
| // TODO Remove this field, use Router.routerId ? | ||
| public String routerId; |
| public Response health() { | ||
| if (router.graph.updaterManager != null) { | ||
| Collection<String> waitingUpdaters = router.graph.updaterManager.waitingUpdaters(); | ||
| var waitingForUpdaters = router.graph.updaterManager.listNonePrimedUpdaters(); |
Member
There was a problem hiding this comment.
I think you should change the method name to listUnprimedUpdaters. I was a little confused at first.
| } | ||
|
|
||
| /** | ||
| * This method start a task during startup, witch update the 'numberOfNonePrimedUpdaters'. It |
Member
There was a problem hiding this comment.
Rename the reference to numberOfNonePrimedUpdaters.
leonardehrenfried
previously approved these changes
Nov 16, 2021
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
A couple of small comments about names.
leonardehrenfried
approved these changes
Nov 17, 2021
hannesj
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging the first time all updaters report being initialized and instance is ready to process requests. This makes it easier to calculate complete startup-time.