Update all timers to micrometer instances#3744
Merged
Merged
Conversation
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Looks very good but I picked up on a few small issues.
t2gran
reviewed
Nov 16, 2021
t2gran
requested changes
Nov 16, 2021
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
This looks good. I will run the SpeedTest with my old benchmark testdata set and post the results.
leonardehrenfried
requested changes
Nov 16, 2021
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I left a few comments.
Member
|
I ran the SpeedTest using the code from this PR. I think this PR is good to go, but we need to look at why the heuristic is so slow. The results are here #3748. I also noticed that in some cases we get long access/egress - but that might be because I used a new |
…sultPrinter.java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
Contributor
Author
|
Thanks for the review. I've addressed the issues raised. |
flaktack
reviewed
Nov 23, 2021
…sultPrinter.java Co-authored-by: Zsombor Welker <flaktack@users.noreply.github.com>
leonardehrenfried
previously approved these changes
Nov 25, 2021
leonardehrenfried
approved these changes
Nov 30, 2021
t2gran
self-requested a review
November 30, 2021 10:01
t2gran
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes both
WorkerPerformanceTimersandDebugTimingAggregatorto use micrometer Timing instances, in order to improve the monitoring capabilities of OTP.It also:
DebugTimingAggregatorin order for us to be able to send them to the user if requested.SpeedTest, which previously caused NPEsUnit tests
This is mostly refactoring, so existing tests continue to work.
Code style
Code style followed
Documentation
Added Javadoc for
TransmodelAPIParameters