Conversation
... so that the networks used during planning may be restricted.
... to limit the used vehicle parkings.
… = to be present Vehicle parking tags may contain an (=) when specified for requiredVehicleParkingTags / bannedVehicleParkingTags.
leonardehrenfried
left a comment
There was a problem hiding this comment.
We at team stadtnavi have been running this code in production for a few months and it's very useful to us, so I approve it being merged.
I picked up on a duplicate method that can potentially be removed.
optionsome
left a comment
There was a problem hiding this comment.
With these current tag options the requiredVehicleParkingTags is probably sufficient. However, I think at some point we might want to allow white listing based on logical or operators too. We could make a separate parameter that expects one of the defined tags to be present but the optimal solution would be to have parameter that would allow to use both "and" and "or" operators. I'm not sure how easy it would be define such format.
We also discussed this today and came to the conclusion that the current implementation is ok for now. If someone has a need for "or" operators we can change the internal model later to support that and implement it in some graphQL API, for example. |
optionsome
left a comment
There was a problem hiding this comment.
I did purely a code review. I'll probably test at least the vehiclerental parameters soon as I plan to add them to legacy graphql API unless someone else has already done that somewhere/is planning to do it.
Summary
Four new parameters are added to
RoutingRequestandRoutingResource, which allow limiting the used vehicle rental / parking place bynetwork/tags:allowedVehicleRentalNetworks/bannedVehicleRentalNetworksrequiredVehicleParkingTags/bannedVehicleParkingTagsA few missing parameters are also added to
RoutingResource:bikeParkCost,bikeParkTime,carParkCost,carParkTime.For vehicle rental:
For vehicle parking -- tags are currently created from OSM tags (
fee,supervised,covered,surveillance):requiredVehicleParkingTagsis specified, than all tags must be presentbannedVehicleParkingTagsis specified, than non of the tags may be presentIssue
#3432
Unit tests
☑️
Code style
☑️
Documentation
No changes.