Skip to content

Simple implementation of horizontally moving elevators (Elevator way) - #3750

Merged
optionsome merged 5 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:DT-4555
Jan 27, 2022
Merged

Simple implementation of horizontally moving elevators (Elevator way)#3750
optionsome merged 5 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:DT-4555

Conversation

@Antiik91

Copy link
Copy Markdown
Contributor

Summary

This PR implements support horizontally moving elevators.

accessible_elevator

Issue

closes #3749

Unit tests

No new tests added, verified with manual testing.

Code style

Used the intellij formatting rules

Documentation

Not needed ?

Changelog

From title

@Antiik91
Antiik91 requested a review from a team as a code owner November 19, 2021 12:48

@hannesj hannesj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stylistic fixes.

@t2gran t2gran added this to the 2.1 milestone Nov 23, 2021
@t2gran t2gran added the !Improvement A functional improvement or micro feature label Nov 23, 2021
@leonardehrenfried

Copy link
Copy Markdown
Member

We discussed in the meeting that we want to also parse the duration from the OSM network.

https://wiki.openstreetmap.org/wiki/Key:duration

@vesameskanen

vesameskanen commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Another thought: should we actually assume that biking is not allowed, unless bicycle=yes is set? Currently we automatically assume that car permission is excluded, too. Opinions? Maybe a bike fits in whenever a wheelchair does.

@t2gran

t2gran commented Nov 23, 2021

Copy link
Copy Markdown
Member

No strong opinions here, but I vote for: "biking is not allowed, unless bicycle=yes". The most common case I think is to NOT use the elevator. Personally I am more likely to walk the bike down the stairs, then to take an elevator. Since, walking the bike will produce a path were biking is not allowed the side-effects should be minimal.

@leonardehrenfried

Copy link
Copy Markdown
Member

I also think that it shouldn't have bike permissions, otherwise it will be presented as "cycle on horizontal elevator", won't it? If it's presented as "get off bike, and walk it onto the elevator" I think it's ok.

@hannesj

hannesj commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

There seems to be some extra files included now

@Antiik91
Antiik91 marked this pull request as draft January 18, 2022 09:44
@t2gran
t2gran marked this pull request as ready for review January 20, 2022 14:50
@t2gran

t2gran commented Jan 25, 2022

Copy link
Copy Markdown
Member

@Antiik91 I think you should take a decision - with regard to supporting bicycle. We can always improve later if it tuns out to be insufficient.

@Antiik91

Copy link
Copy Markdown
Contributor Author

There seems to be some extra files included now

This is now fixed

…nStreetMapModule.java

Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
Antiik91 and others added 2 commits January 26, 2022 11:09
…nStreetMapModule.java

Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
…nStreetMapModule.java

Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>

@t2gran t2gran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this for @leonardehrenfried, since he already approved it.

@optionsome
optionsome merged commit 029f753 into opentripplanner:dev-2.x Jan 27, 2022
@optionsome
optionsome deleted the DT-4555 branch January 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support horizontally moving elevators (Elevator ways)

6 participants