Simple implementation of horizontally moving elevators (Elevator way) - #3750
Conversation
hannesj
left a comment
There was a problem hiding this comment.
Just minor stylistic fixes.
|
We discussed in the meeting that we want to also parse the duration from the OSM network. |
|
Another thought: should we actually assume that biking is not allowed, unless bicycle=yes is set? Currently we automatically assume that car permission is excluded, too. Opinions? Maybe a bike fits in whenever a wheelchair does. |
|
No strong opinions here, but I vote for: "biking is not allowed, unless bicycle=yes". The most common case I think is to NOT use the elevator. Personally I am more likely to walk the bike down the stairs, then to take an elevator. Since, walking the bike will produce a path were biking is not allowed the side-effects should be minimal. |
|
I also think that it shouldn't have bike permissions, otherwise it will be presented as "cycle on horizontal elevator", won't it? If it's presented as "get off bike, and walk it onto the elevator" I think it's ok. |
|
There seems to be some extra files included now |
|
@Antiik91 I think you should take a decision - with regard to supporting bicycle. We can always improve later if it tuns out to be insufficient. |
This is now fixed |
…nStreetMapModule.java Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
…nStreetMapModule.java Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
…nStreetMapModule.java Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
t2gran
left a comment
There was a problem hiding this comment.
I will approve this for @leonardehrenfried, since he already approved it.
Summary
This PR implements support horizontally moving elevators.
Issue
closes #3749
Unit tests
No new tests added, verified with manual testing.
Code style
Used the intellij formatting rules
Documentation
Not needed ?
Changelog
From title