Repository navigation
Add mode from parent StopPlace for Quays in Netex mapper - #3751
Merged
Merged
Conversation
hannesj
added
!Bug
hannesj
added
!Improvement
leonardehrenfried
previously approved these changes
Nov 22, 2021
t2gran
reviewed
Nov 23, 2021
leonardehrenfried
approved these changes
Nov 25, 2021
t2gran
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add mode from parent StopPlace for Quays in Netex mapper. It seems we already had the correct mapper, but it was not used anywhere.
Unit tests
Mapper already has unit test coverage
Code style
Code style followed
Documentation
No need to update
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.