Remove old visibility graph library from walkable area builder#3753
Merged
hannesj merged 24 commits intoNov 30, 2021
Conversation
hannesj
added
!Bug
This was lost in recent merge. Needed for not linking vehicle parking twice, when split graph build in two.
Currently it does not reflect holes created later on
…he same AreaGroup
Otherwise the areaEdge is pruned as an island leaving potentially dangling references.
hannesj
force-pushed
the
otp2_remove_platform_linking
branch
from
6214987 to
f6a1ea3
Compare
Member
|
While looking through some other code I noticed this: https://github.com/opentripplanner/OpenTripPlanner/blob/da742d9dbdef8df40577b572e5c004109ec0c29b/src/main/java/org/opentripplanner/graph_builder/module/osm/OpenStreetMapModule.java#L1331-L1330 I think it applies. :) |
abyrd
approved these changes
Nov 30, 2021
Member
abyrd
left a comment
abyrd
left a comment
There was a problem hiding this comment.
This has been tested by others on several data sets, and I have reviewed the code. It seems like a good change set. @hannesj would like to make some performance improvements related to convex/concave sections of polygons but will do that in a separate PR.
Member
|
I ran it on one of my data sets and it looks great. |
leonardehrenfried
approved these changes
Nov 30, 2021
t2gran
pushed a commit
that referenced
this pull request
Nov 30, 2021
Contributor
Author
|
We agreed to take a look at the performance todos in a separate pull request, as this only affects graph build performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The visibility graph library was not used previously for anything, except converting the areas to JTS polygons. This branch reworks the walkable area builder to directly work on the JTS polygons.
This also removes the old platform linker, as it had serious bugs in it, as well as other minor improvements to the walkable area builder
Issue
Oslo S:
Before
After
Detail
Jernbanetorget:
Before
After
Fixes #2472
#3152 (comment)
Unit tests
Unit test for platform linker was modified. It would be nice to get more test coverage for this functionality.
Code style
Code style followed
Documentation
No changes needed. This is mostly a refactoring, with all config options left as is