Data overlay sandbox feature - #3760
Merged
leonardehrenfried merged 138 commits intoDec 22, 2021
Merged
Conversation
# Conflicts: # src/main/java/org/opentripplanner/graph_builder/GraphBuilderDataSources.java # src/test/java/org/opentripplanner/graph_builder/module/osm/TestOpenStreetMapGraphBuilder.java
…air quality parameters, removed unused files from AirQuality
…iltering during request building, settings.json parsing for the router). UNTESTED todo: add parameter data filtering logic
… for one variable)
…son, penalty calculation from formula, null checks
fixed formatting and javadocs according to review
types, request parameters checks
…r airquality.nc file and which should be placed into "graphs" folder
added settings.json
added 3d and 4d netcdf array processing for number variables
added different date formats
…e validity checks to json settings
| { "otpFeatures": { "DataOverlay" : true } } | ||
| ``` | ||
|
|
||
| TODO - Katja, please provide other instructions here |
Contributor
There was a problem hiding this comment.
@leonardehrenfried Not done yet, I will add more detailed description of how to set the configuration for the data file
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
t2gran
reviewed
Dec 20, 2021
| import java.util.List; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.CompletionException; | ||
| import org.opentripplanner.ext.dataoverlay.routing.DataOverlayContext; |
Member
There was a problem hiding this comment.
Suggested change
| import org.opentripplanner.ext.dataoverlay.routing.DataOverlayContext; |
t2gran
reviewed
Dec 20, 2021
t2gran
reviewed
Dec 20, 2021
t2gran
reviewed
Dec 20, 2021
t2gran
reviewed
Dec 20, 2021
…ig.java Co-authored-by: Thomas Gran <t2gran@gmail.com>
Co-authored-by: Thomas Gran <t2gran@gmail.com>
…ata overlay parameters only if they are not empty
typo fix
t2gran
previously approved these changes
Dec 21, 2021
leonardehrenfried
previously approved these changes
Dec 21, 2021
…feature # Conflicts: # src/main/java/org/opentripplanner/api/common/RoutingResource.java
kaeline
dismissed stale reviews from leonardehrenfried and t2gran
via
December 21, 2021 18:50
846536c
t2gran
approved these changes
Dec 21, 2021
leonardehrenfried
approved these changes
Dec 21, 2021
Contributor
Author
|
@t2gran @leonardehrenfried unfortunately we can not merge without write access to this repo. Could you do it? |
Member
|
🍾 |
t2gran
pushed a commit
that referenced
this pull request
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Instructions
otp-config.json file must have a feature enabled as follows:
Then provide a
data-overlay-config.jsonand a data file itself in a NetCDF (.nc, .nc3, .nc4) format.Start the graph building process as usually. Your custom overlay data will populate the graph edges with values. You will also get custom
/otp/routers/default/planendpoint request parameters available (defined in thedata-overlay-config.json).Please scroll to the bottom for the
data-overlay-config.jsonexample.Summary
PR adds a feature of a map grid data "overlay" or population. You could take i.e weather, air quality, traffic and e.t.c data in a NetCDF format and get the map populated by this data. Routing can be affected by this data if you use the custom request parameters defined in the
data-overlay-config.jsonIssue
Code style
Documentation
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.Required
data-overlay-config.jsonfile example