Walkable area builder improvements#3765
Merged
hannesj merged 6 commits intoDec 14, 2021
Merged
Conversation
Proportion of getDataForWay in WalkableAreaBuilder went from 9% to less than 1%
f8ca7cf to
5bbeb60
Compare
vesameskanen
approved these changes
Dec 13, 2021
Member
|
I checked it with one of my data sets and it looks good. |
leonardehrenfried
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in OTP meeting last week, we decided to do performance improvements for the walkable area builder at a later stage. This pull request contains two of those. The first one is limiting the visibility nodes to only use convex points in a polygon. This reduces the build time of the Norwegian graph from ~3 minutes and 45 seconds to ~2min 15 seconds. The second one caches the way properties, which further reduces the build time to ~2minutes.
This also fixes a couple of issues with the builder:
Unit tests
Unit test for calculating convex points in a polygon added
Code style
Code style followed
Documentation
No updates required
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.