Skip to content

Walkable area builder improvements#3765

Merged
hannesj merged 6 commits into
opentripplanner:dev-2.xfrom
entur:otp2_walkable_area_builder_fixes
Dec 14, 2021
Merged

Walkable area builder improvements#3765
hannesj merged 6 commits into
opentripplanner:dev-2.xfrom
entur:otp2_walkable_area_builder_fixes

Conversation

@hannesj

@hannesj hannesj commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Summary

As discussed in OTP meeting last week, we decided to do performance improvements for the walkable area builder at a later stage. This pull request contains two of those. The first one is limiting the visibility nodes to only use convex points in a polygon. This reduces the build time of the Norwegian graph from ~3 minutes and 45 seconds to ~2min 15 seconds. The second one caches the way properties, which further reduces the build time to ~2minutes.

This also fixes a couple of issues with the builder:

  • Do not split edges less than 10 cm.
  • Make sure that all area edges are connected properly
  • Run island pruning only after stop linking, even when building the street graph separately
  • Add issue about unconnected areas

Unit tests

Unit test for calculating convex points in a polygon added

Code style

Code style followed

Documentation

No updates required

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add [changelog skip] in the title.

Proportion of getDataForWay in WalkableAreaBuilder went from 9% to less than 1%
@hannesj hannesj requested a review from vesameskanen December 6, 2021 08:47
@hannesj hannesj requested a review from a team as a code owner December 6, 2021 08:47
@hannesj hannesj force-pushed the otp2_walkable_area_builder_fixes branch from f8ca7cf to 5bbeb60 Compare December 6, 2021 15:38
@t2gran t2gran added this to the 2.1 milestone Dec 7, 2021
@t2gran t2gran added the !Improvement A functional improvement or micro feature label Dec 7, 2021
@t2gran t2gran requested a review from abyrd December 7, 2021 11:08
@hannesj hannesj added the Entur Test This is currently being tested at Entur label Dec 7, 2021
@leonardehrenfried

Copy link
Copy Markdown
Member

I checked it with one of my data sets and it looks good.

@hannesj hannesj merged commit f8d1edc into opentripplanner:dev-2.x Dec 14, 2021
t2gran pushed a commit that referenced this pull request Dec 14, 2021
@hannesj hannesj deleted the otp2_walkable_area_builder_fixes branch December 14, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur Test This is currently being tested at Entur !Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants