Parallelise computing of trip pattern geometries - #3766
Merged
leonardehrenfried merged 2 commits intoDec 9, 2021
Merged
Conversation
Member
Author
|
@vesameskanen @optionsome If you're concerned about recent graph build slowdowns, you could give this a try. |
t2gran
reviewed
Dec 7, 2021
Co-authored-by: Thomas Gran <t2gran@gmail.com>
hannesj
approved these changes
Dec 7, 2021
Member
Author
|
@abyrd BTW, we talked about a 16 core machine leading to a 7-fold increase. I just rechecked the build machine and it only has 12 cores so it's not as bad as I originally thought. |
t2gran
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that when building a Norway graph 7 out of 20 minutes is taken up computing the trip pattern geometries. This process is run serially when it's quite parallelisable.
With these minor modifications I managed to reduce the graph build time from 20 to 13 minutes on my 16 core test machine.
Unit tests
n/a
Code style
yes
Documentation
n/a