Skip to content

Contributing Guide - #3769

Merged
abyrd merged 4 commits into
dev-2.xfrom
contributing-templates
Jan 25, 2022
Merged

Contributing Guide#3769
abyrd merged 4 commits into
dev-2.xfrom
contributing-templates

Conversation

@abyrd

@abyrd abyrd commented Dec 7, 2021

Copy link
Copy Markdown
Member

This adds a CONTRIBUTING.md and also updates some broken links and outdated information on the History page.

@abyrd abyrd changed the title Contributing templates Contributing Guide Dec 7, 2021
@t2gran t2gran added this to the 2.1 milestone Dec 7, 2021
@t2gran t2gran added the !Documentation Improve documentation targeting users and/or developers. label Dec 7, 2021
@t2gran
t2gran self-requested a review December 7, 2021 10:25
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
- Tie such series of PRs together with an "epic issue" that explains the overall plan.
- Use Github issue references ("addresses #12" etc.) to connect PRs and issues together.
- Consider squashing and rebasing to make the PR history easier to understand, eliminating extra "noise" commits like accidental changes to organization specific code, abandoned experiments, or reverted configuration changes.
- If possible, please describe your proposed changes in advance before proceeding too far with development. There are often other people working on the same problem. Coordinating with them can avoid a lot of duplicated effort, conflict, and technical debt.

@t2gran t2gran Dec 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think this is the most important thing - so maybe we should put it first. Maybe:

Suggested change
- If possible, please describe your proposed changes in advance before proceeding too far with development. There are often other people working on the same problem. Coordinating with them can avoid a lot of duplicated effort, conflict, and technical debt.
- If possible, please discuss your proposed changes in advance before proceeding too far with development. There are often other input/angles/thoughts and/or plans on the same problem. Coordinating with other OTP developers can avoid a lot of duplicated effort, conflict, and technical debt and make the review a lot easier.

There are often other input/angles/thoughts and/or plans on the same problem.

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good description and explanation of the current development process.

Comment thread CONTRIBUTING.md Outdated

Any message posted there will be seen by most of the contributors, some of whom work on OTP full time. It will also create a record of the discussion that will be useful to the larger community and often leads to issues being discussed at the twice-weekly development meetings.

OTP development meetings occur every Tuesday at 10 AM Central European time and Thursday at 15:00 Central European Time on https://meet.google.com/qwh-xzbz-atr. These meetings are open to anyone who wants to join, even if you simply want to observe the process or ask a few questions. The meeting times have been deliberately chosen to allow participation during regular business hours across as many time zones as possible, from the US (east coast) through Europe and Asia.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion about this yesterday. We will change the meeting link to be always static (currently we have had to use different link if the host is not able to join). It can still be debated if we should define the meeting times in text here and/or use an online calendar that can be updated when, in the rare cases, we have to reschedule a meeting.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this describe the current situation; hence can be merged. When we improve we will of cause update the document. I agree with @optionsome that we should aim for an online calendar (and link to it from here).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@novalis

novalis commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

Maybe add some sort of code of conduct? https://www.contributor-covenant.org/version/2/1/code_of_conduct/ is one which is extremely commonly used.

Comment thread CONTRIBUTING.md Outdated

## Primary Channels of Communication

If you have any questions about problems you are encountering with code, deployment, documentation, or development coordination please don't hesitate to post to the OpenTripPlanner discussion groups. These are Google Groups which can be accessed as web forums or as traditional email mailing lists:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comma after coordination.

@t2gran
t2gran marked this pull request as ready for review January 20, 2022 14:49
@t2gran
t2gran requested a review from a team as a code owner January 20, 2022 14:49

@t2gran t2gran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abyrd for this excellent description of the current process.

@abyrd
abyrd merged commit 8877b9c into dev-2.x Jan 25, 2022
@abyrd
abyrd deleted the contributing-templates branch January 25, 2022 10:36
t2gran pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Documentation Improve documentation targeting users and/or developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants