Remove outdated realtime-update from TimetableSnapshot - #3770
Merged
t2gran merged 11 commits intoJan 25, 2022
Conversation
t2gran
marked this pull request as draft
December 14, 2021 11:06
hannesj
reviewed
Dec 14, 2021
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
hannesj
previously approved these changes
Dec 15, 2021
hannesj
marked this pull request as ready for review
January 13, 2022 08:39
Contributor
|
This should now be ready for review |
t2gran
requested review from
optionsome and
t2gran
and removed request for
abyrd
January 13, 2022 14:44
optionsome
reviewed
Jan 14, 2022
optionsome
left a comment
optionsome
left a comment
Member
There was a problem hiding this comment.
I wouldn't mind if there was a better test coverage for these realtime trip updates as it's easy to break something while fixing something else but I can approve this even without added tests.
…tSource.java Co-authored-by: Joel Lappalainen <lappalj8@gmail.com>
t2gran
approved these changes
Jan 24, 2022
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
From a technical point of view, this looks ok.
optionsome
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #3732 is caused by multiple versions of the realtime-updated trip - one for each separate StopPattern - being kept after it has been replaced by a new update. (Outdated versions are flagged as "cancelled")
This PR removes the outdated/replaced updates from the TimetableSnapshot entirely - resulting in OTP having only one realtime-updated version of each trip.
Issue
Closes #3732