Fix checking allowed boarding/alighting for unscheduled flex trips#3782
Merged
hannesj merged 4 commits intoDec 14, 2021
Conversation
These are already checked in getFromIndex and getToIndex
The reading and mapping of the Norwegian Netex files went from 2min 25sec to 1min 15sec
Member
|
First of all, sorry for breaking this. This PR has made me understand more how these access/egrees paths should be calculated. I just checked the Aspen feed and it still works.
Do you have a feed with an unscheduled trip that contains more than one stop time because so far I have only seen ones with a single one. Then I could add a test that those work. |
leonardehrenfried
previously approved these changes
Dec 13, 2021
….java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
Contributor
Author
No problem. This should have been caught by the review last time. |
leonardehrenfried
approved these changes
Dec 13, 2021
t2gran
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #3720 the boarding/alighting constraints for unscheduled trips are checked from the wrong stop index. This fixes that
Unit tests
None
Code style
Code style followed
Documentation
No updates required
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.