Skip to content

Remove build parameter 'useTransfersTxt' - #3791

Merged
leonardehrenfried merged 1 commit into
opentripplanner:dev-2.xfrom
ibi-group:remove-transfers-txt-config
Dec 16, 2021
Merged

Remove build parameter 'useTransfersTxt'#3791
leonardehrenfried merged 1 commit into
opentripplanner:dev-2.xfrom
ibi-group:remove-transfers-txt-config

Conversation

@leonardehrenfried

@leonardehrenfried leonardehrenfried commented Dec 16, 2021

Copy link
Copy Markdown
Member

Summary

As discussed in the dev meeting today we decided the parameter useTransfersTxt. Reasons for removal are the following:

  • the name is wrong: it doesn't enable or disable the transfers.txt but the calculation of the OSM transfers
  • none of us found a use case were turning off the OSM transfers was a good idea

Instead we want to implement a fallback logic like this:

  • if we have a transfer in transfers.txt use that
  • if not then use pathways.txt
  • if not then use OSM based transfers

This will happen in a separate PR.

Issue

n/a

Unit tests

n/a

Code style

Yes.

Documentation

Documentation removed.

@leonardehrenfried
leonardehrenfried requested a review from a team as a code owner December 16, 2021 14:39
@t2gran t2gran added this to the 2.1 milestone Dec 16, 2021
@t2gran t2gran added the !Technical Debt Improve code quality, no functional changes. label Dec 16, 2021
@leonardehrenfried
leonardehrenfried merged commit 6b8912a into opentripplanner:dev-2.x Dec 16, 2021
@leonardehrenfried
leonardehrenfried deleted the remove-transfers-txt-config branch December 16, 2021 16:55
t2gran pushed a commit that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants