Not allowed transfers and support for GTFS transfer points

[t2gran]

Summary

Explain in one or two sentences what this PR achieves.

Issue

Link to or create an issue that describes the relevant feature or bug.
You need not create an issue for small bugfixes and code cleanups, but in that case do describe the problem clearly and completely in the "summary" section above.
In the linked issue (or summary section for smaller PRs) please describe:

• Motivation (problem or need encountered)
• How the code works
• Technical approach and any design considerations or decisions

Remember that the PR will be reviewed by another developer who may not be familiar with your use cases or the code you're modifying. It generally takes much less effort for the author of a PR to explain the background and technical details than for a reviewer to infer or deduce them. PRs may be closed if they or their linked issues do not contain sufficient information for a reviewer to proceed.

Add GitHub keywords to this PR's description, for example:

closes #45

Unit tests

Write a few words on how the new code is tested.

• Were unit tests added/updated?
• Was any manual verification done?
• Any observations on changes to performance?
• Was the code designed so it is unit testable?
• Were any tests applied to the smallest appropriate unit?
• Do all tests pass the continuous integration service?

Code style

Have you followed the suggested code style?

Documentation

• Have you added documentation in code covering design and rationale behind the code?
• Were all non-trivial public classes and methods documented with Javadoc?
• Were any new configuration options added? If so were the tables in the configuration documentation updated?

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add [changelog skip] in the title.

[leonardehrenfried]

I've made a few comments about names.

[leonardehrenfried]

I ran this with the GTFS Flex example feed and there I saw a NPE when starting up OTP:

11:17:28.093 ERROR (OTPMain.java:59) An uncaught error occurred inside OTP: null
java.lang.NullPointerException: null
	at org.opentripplanner.routing.algorithm.raptor.transit.constrainedtransfer.TransferIndexGenerator.findTPoints(TransferIndexGenerator.java:134)
	at org.opentripplanner.routing.algorithm.raptor.transit.constrainedtransfer.TransferIndexGenerator.findTPoints(TransferIndexGenerator.java:101)
	at org.opentripplanner.routing.algorithm.raptor.transit.constrainedtransfer.TransferIndexGenerator.generateTransfers(TransferIndexGenerator.java:53)
	at org.opentripplanner.routing.algorithm.raptor.transit.mappers.TransitLayerMapper.map(TransitLayerMapper.java:84)
	at org.opentripplanner.routing.algorithm.raptor.transit.mappers.TransitLayerMapper.map(TransitLayerMapper.java:56)
	at org.opentripplanner.standalone.server.Router.startup(Router.java:92)
	at org.opentripplanner.standalone.OTPMain.startOTPServer(OTPMain.java:167)
	at org.opentripplanner.standalone.OTPMain.main(OTPMain.java:52)

So it seems that you can have a stop with which doesn't have a pattern.

[leonardehrenfried]

I'm going to turn off the codecov bot.

[leonardehrenfried]

I've committed the configuration file directly to dev-2.x. If you merge again, the codecov bot will disappear.

[leonardehrenfried]

I tested the not-allowed-transfers part of this PR and it does exactly what it's supposed to do.

Regular Boston feed

Modified Boston feed where with a not-allowed-transfer at the previous transfer stop

This leads to a transfer to a different stop. 👍