Add reading and exposing of Netex submodes#3793
Merged
Merged
Conversation
hannesj
changed the title
…il/railReplacementBus
hannesj
force-pushed
the
otp2_submodes_hannes
branch
from
b261191 to
1d2a571
Compare
optionsome
previously approved these changes
Jan 4, 2022
optionsome
left a comment
optionsome
left a comment
Member
There was a problem hiding this comment.
Looked at non netex/siri code and tested with legacy graphql api and REST API
leonardehrenfried
previously approved these changes
Jan 5, 2022
t2gran
requested changes
Jan 6, 2022
hannesj
force-pushed
the
otp2_submodes_hannes
branch
from
048ad27 to
b09812a
Compare
Co-authored-by: Thomas Gran <t2gran@gmail.com>
hannesj
force-pushed
the
otp2_submodes_hannes
branch
from
b09812a to
907a752
Compare
t2gran
approved these changes
Jan 7, 2022
leonardehrenfried
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #3115, the initial approach should be less invasive. This PR adds reading and exposing the Netex submodes on the Transmodel API, without touching the code relating to transit modes.
Issue
Related to #3105
Unit tests
Some tests added
Code style
Code style followed
Documentation
Transmodel API documentation updated
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.