Read in flex window from Netex feeds #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
previously approved these changes
Jan 6, 2022
t2gran
requested changes
Jan 6, 2022
src/main/java/org/opentripplanner/netex/mapping/StopTimesMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/netex/mapping/StopTimesMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/netex/mapping/StopTimesMapper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
t2gran
approved these changes
Jan 10, 2022
leonardehrenfried
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently Netex feeds only support reading in a fixed stop time even for flex trips. There is a workaround for converting these to flex windows. There has been since a clarification on the standard regarding how to read these windows. This adds support for reading those.
Unit tests
None changed
Code style
Code style followed
Documentation
No updates required
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add
[changelog skip]in the title.