Read translations from GTFS and Netex sources for stop names

[hannesj]

Summary

Read translations for stop names from Netex feeds and expose them through the Transmodel API.

Issue

Built on top of #3781

Unit tests

None included

Code style

✅

Documentation

Transmodel API description added

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add [changelog skip] in the title.

[leonardehrenfried]

I think there is quite a bit of duplication here and in the URL. Can you make this a little DRY?

[hannesj]

This uses LegacyGraphQLUtils.getLocale now

[hannesj]

At least with the GraphQL API it seems to now default to using the translated language when the requested language doesn't match which seems a bit problematic. Also, there is some issue with null stop URLs when trying to fetch them through the API.

This should be fixed now

[optionsome]

Fetching stop urls when they are not defined in data still causes NPE:

17:28:22.602 WARN (SimpleDataFetcherExceptionHandler.java:27) Exception while fetching data (/stops[1736]/url) : null
java.lang.NullPointerException: null
	at org.opentripplanner.ext.legacygraphqlapi.datafetchers.LegacyGraphQLStopImpl.lambda$url$18(LegacyGraphQLStopImpl.java:123)
	at org.opentripplanner.ext.legacygraphqlapi.datafetchers.LegacyGraphQLStopImpl.getValue(LegacyGraphQLStopImpl.java:464)

[optionsome]

Thanks for doing these changes. Everything seems to work now and the code looks good. Just one question, do we need to update the serialization version due to the String -> I18NString type change in the stop model?

[hannesj]

Just one question, do we need to update the serialization version due to the String -> I18NString type change in the stop model?

True. Done!

[optionsome]

I think the serialization version was also changed to 19 in dev-2.x, you have to update it again. We could discuss today in the developer meeting if it would be possible to automate the serialization version update similarly as we have done with the changelog (maybe based on some label of a merged pr?).